-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct variations count when generating a single variation #37876
Conversation
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: a3eee81
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
plugins/woocommerce/client/legacy/js/admin/meta-boxes-product-variation.js
Outdated
Show resolved
Hide resolved
plugins/woocommerce/client/legacy/js/admin/meta-boxes-product-variation.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @mattsherman. The changes look good, I only left a couple of comments.
Maybe I have a building problem, but I'm seeing the confirmation window like this:
d4dec49
to
4b1175e
Compare
This happens when the legacy JS isn't built. I just hit it when forgetting to |
@octaedro Ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mattsherman! LGTM
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR corrects the variations count shown when using the "Generate variations" button and a single variation is generated.
Before
After
Closes #37644.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Products
>Add New
>Product data
.Variable product
and go to theAttributes
tab.Variations
tab and clickGenerate variations
.Add manually
andRemove
to add variations and verify the count remains correct.